Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(naming): query service subscriber list #189

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

a981008
Copy link
Contributor

@a981008 a981008 commented Dec 29, 2024

Refs #73

@a981008
Copy link
Contributor Author

a981008 commented Dec 29, 2024

抱歉,当我写完代码时,发现原来已经有一个 PR(#134)了。
不过卡在最后一步签署协议好久了,如果不介意的话可以合并我这个。

@heqingpan
Copy link
Collaborator

好的,我后面抽空看看。

如果你这个比较完善的话,就合并你这个。

@heqingpan
Copy link
Collaborator

看了一遍没大问题,有一个待处理项处理后就可以合并。

前一个PR是配置中心的,你这个是注册中心的其实两者不冲突。

@a981008
Copy link
Contributor Author

a981008 commented Dec 31, 2024

好的,后面我会在前端项目提交一个 pr,用来显示订阅者列表

@heqingpan
Copy link
Collaborator

本地使用 naming-register 测试发现,一个客户端注册多个服务实例,只显示一条定阅信息。

image

image

@a981008
Copy link
Contributor Author

a981008 commented Jan 2, 2025

貌似没什么问题,naming-register 中只有一个订阅。

@heqingpan
Copy link
Collaborator

貌似没什么问题,naming-register 中只有一个订阅。

有道理,是我搞错了😂

@heqingpan heqingpan merged commit 97859ca into nacos-group:master Jan 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants